Skip to content

feat: Added AppendSpan #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2024
Merged

feat: Added AppendSpan #209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b23a8c8
feat: Added AppendSpan
bCamba Dec 18, 2024
f16c815
docs: Added xmldoc for AppendSpan
bCamba Dec 18, 2024
7671c1a
docs: Added AppendSpan to ChangeLog
bCamba Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/LinkDotNet.StringBuilder/ValueStringBuilder.Append.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,19 @@ public void AppendLine(scoped ReadOnlySpan<char> str)
Append(string.Concat(str, Environment.NewLine));
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public Span<char> AppendSpan(int length)
Copy link
Owner

@linkdotnet linkdotnet Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an xmldoc?

{
int origPos = bufferPosition;
if (origPos > buffer.Length - length)
{
Grow(length);
}

bufferPosition = origPos + length;
return buffer.Slice(origPos, length);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private void AppendSpanFormattable<T>(T value, ReadOnlySpan<char> format = default, int bufferSize = 36)
where T : ISpanFormattable
Expand Down
12 changes: 12 additions & 0 deletions tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.Append.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,18 @@ public void ShouldAppendLine()
stringBuilder.ToString().Should().Contain("Hello").And.Contain(Environment.NewLine);
}

[Fact]
public void ShouldAppendSpan()
{
using var stringBuilder = new ValueStringBuilder();

var returned = stringBuilder.AppendSpan(2);

stringBuilder.Length.Should().Be(2);

stringBuilder.ToString().Should().Be(returned.ToString());
}

[Fact]
public void ShouldOnlyAddNewline()
{
Expand Down
Loading