Add more rune overloads #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkdotnet
reviewed
Jan 13, 2025
CHANGELOG.md
Outdated
| - Added `Append(Rune)` overload | ||
| - Added `AppendJoin(Rune, IEnumerable<string?>)` overload | ||
| - Added `AppendJoin<T>(Rune, IEnumerable<T>)` overload | ||
| - Added `Replace(Rune, Rune)` overload |
Owner
There was a problem hiding this comment.
As I already released a version with the other ones, you would have to add a new ### ADDED under the unreleased part.
Something along the line like:
## Unreleased
### Added
- Added `Replace(Rune, Rune)` overload
- Added `Replace(Rune, Rune, int, int)` overload
Owner
|
Much appreciated - besides the |
linkdotnet
approved these changes
Jan 13, 2025
Owner
linkdotnet
left a comment
linkdotnet
left a comment
There was a problem hiding this comment.
Amazing! Thanks. Will make a release
Owner
|
Oh noy - I did screw up the merge. Could you force-push your version and resolve the merge conflict? |
Contributor
Author
All good, I force-pushed the last commit. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace(Rune, Rune)overloadReplace(Rune, Rune, int, int)overload