Skip to content

Optimize & simplify Replace(char, char) #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Optimize & simplify Replace(char, char) #241

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dac463b
Perf optimization & simplification in Replace
Joy-less Feb 28, 2025
8814b6a
Optimize replace with one-length spans
Joy-less Mar 1, 2025
9939cd6
Update CHANGELOG.md
Joy-less Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/LinkDotNet.StringBuilder/ValueStringBuilder.Replace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@ public readonly void Replace(char oldValue, char newValue, int startIndex, int c
ArgumentOutOfRangeException.ThrowIfLessThan(startIndex, 0);
ArgumentOutOfRangeException.ThrowIfGreaterThan(startIndex + count, Length);

for (var i = startIndex; i < startIndex + count; i++)
{
if (buffer[i] == oldValue)
{
buffer[i] = newValue;
}
}
buffer.Slice(startIndex, count).Replace(oldValue, newValue);
}

/// <summary>
Expand Down Expand Up @@ -97,6 +91,12 @@ public void Replace(scoped ReadOnlySpan<char> oldValue, scoped ReadOnlySpan<char
return;
}

if (oldValue.Length == 1 && newValue.Length == 1)
{
Replace(oldValue[0], newValue[0], startIndex, count);
return;
}

var index = startIndex;
var remainingChars = count;

Expand Down
2 changes: 1 addition & 1 deletion src/LinkDotNet.StringBuilder/ValueStringBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public static ValueStringBuilder ToValueStringBuilder(this System.Text.StringBui
{
ArgumentNullException.ThrowIfNull(builder);

var valueStringBuilder = new ValueStringBuilder();
var valueStringBuilder = new ValueStringBuilder(builder.Length);
foreach (var chunk in builder.GetChunks())
{
valueStringBuilder.Append(chunk.Span);
Expand Down