Merged
Conversation
d35641a to
e705161
Compare
jogrogan
approved these changes
Feb 6, 2025
Collaborator
jogrogan
left a comment
There was a problem hiding this comment.
LGTM, we should probably at some point start a wiki to document some of these properties we have defined
Co-authored-by: Joseph Grogan <jogrogan@linkedin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectionPropertiesparameter to several API methods, includingDeployerProviderandConfigProvider.K8sContextnow constructs anApiClientfrom theconnectionProperties, or failing that, fromkube/config.defaultContext()and related singleton methods, ensuring the driver is re-entrant and can handle simultaneous connections with different configurations.Details
Previously, we treated
K8sContextas a lazy-loaded singleton, which was shared across connections. This was preventing us from productionizing the driver in a multi-tenant service, where different clients may want to use distinct namespaces, usernames, etc. To solve this problem, we now constructK8sContextdynamically from connection-level properties. This required some minor API changes, in order to thread the connection properties through to the various plugins. In particular,DeployerProviderandConfigProvidernow have access to the connection properties.K8sDeployeretc use this to constructApiClients etc.Testing
Verified the driver loads from the CLI, unit tests pass, and integration tests pass.