Fix Backward Compatibility for Convergence Test#1078
Merged
vaibhavjindal merged 2 commits intolinkedin:transformers-5.0.0rc1from Feb 5, 2026
Merged
Fix Backward Compatibility for Convergence Test#1078vaibhavjindal merged 2 commits intolinkedin:transformers-5.0.0rc1from
vaibhavjindal merged 2 commits intolinkedin:transformers-5.0.0rc1from
Conversation
vaibhavjindal
approved these changes
Feb 5, 2026
Collaborator
vaibhavjindal
left a comment
There was a problem hiding this comment.
Amazing work @Mecoli1219! 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores backward compatibility for convergence tests with transformers v4 (v4.49.0 ~ v4.57.6). During the initial development phase for transformers v5 support, backward compatibility was intentionally deprioritized, leading to significant test regressions. This PR fixes those regressions while maintaining a stable foundation for the ongoing v5 integration.
Related Issues & PRs
Details
The current codebase assumes transformers v5 conventions, which broke compatibility with the v4.x series in two major areas:
rope_scaling) since they are unified torope_parametersin transformer v5.Key Fixes:
Testing Done
I ran
python -m pytest test/convergence/*on different versions of transformers on the original branch and after making changes. The result is shown below:All of the failed tests in v5 are inspected carefully that all of them are identical to the previously thrown error.
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence