Skip to content

Conversation

@Manan17
Copy link
Contributor

@Manan17 Manan17 commented Jun 10, 2025

Summary

The docs workflow currently replaces the gh-pages branch with new files due to which the benchmark data is lost. Currently I am disabling this so that we can get the data appended in the gh-pages branch.
Also, modified the script to add commit hashes to a json file, so that we do not call github api to fetch it due to API limitations

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

Copy link
Collaborator

@vaibhavjindal vaibhavjindal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vaibhavjindal vaibhavjindal merged commit c794a8f into linkedin:main Jun 11, 2025
@vaibhavjindal
Copy link
Collaborator

vaibhavjindal commented Jun 11, 2025

@Manan17 looks like there are some issues with the yaml files that we need to fix. We need to fix both the benchmark.yml and docs.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants