Skip to content

Conversation

@j-tyler
Copy link
Contributor

@j-tyler j-tyler commented Dec 15, 2025

Summary

While this log strings and logging operations are not taken when the log level is not at the trace level, if the parameter passed to the log statement is expensive to fetch that price is still paid every time (depending on JIT). To make our expansive logging more performance we wrap trace logs with a conditional check if the parameters passed are classified as potentially expensive.

Testing Done

Should be no functional changes so all existing build and tests should pass.

While this log strings and logging operations are not taken when the log level is not at the
trace level, if the parameter passed to the log statement is expensive to fetch that price is
still paid every time (depending on JIT). To make our expansive logging more performance we wrap
trace logs with a conditional check if the parameters passed are classified as potentially expensive.
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.83%. Comparing base (52ba813) to head (3df3dc5).
⚠️ Report is 333 commits behind head on master.

Files with missing lines Patch % Lines
...va/com/github/ambry/replication/ReplicaThread.java 0.00% 24 Missing and 8 partials ⚠️
...n/java/com/github/ambry/store/PersistentIndex.java 0.00% 16 Missing and 10 partials ⚠️
...java/com/github/ambry/network/SSLTransmission.java 0.00% 5 Missing and 4 partials ⚠️
...in/java/com/github/ambry/store/BlobStoreStats.java 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3185      +/-   ##
============================================
+ Coverage     64.24%   69.83%   +5.58%     
- Complexity    10398    12811    +2413     
============================================
  Files           840      930      +90     
  Lines         71755    79027    +7272     
  Branches       8611     9454     +843     
============================================
+ Hits          46099    55185    +9086     
+ Misses        23004    20906    -2098     
- Partials       2652     2936     +284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@j-tyler j-tyler merged commit 0bd85bb into linkedin:master Dec 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants