Wrap expensive log trace calls with if enabled condition #3185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While this log strings and logging operations are not taken when the log level is not at the trace level, if the parameter passed to the log statement is expensive to fetch that price is still paid every time (depending on JIT). To make our expansive logging more performance we wrap trace logs with a conditional check if the parameters passed are classified as potentially expensive.
Testing Done
Should be no functional changes so all existing build and tests should pass.