Ensure most recent metadata is served despite duplicate version 0's#268
Open
Ensure most recent metadata is served despite duplicate version 0's#268
Conversation
yangyangv2
requested changes
Jun 13, 2023
dao-impl/ebean-dao/src/test/java/com/linkedin/metadata/dao/EbeanLocalDAOTest.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| sb.append(" ORDER BY createdOn DESC"); |
Contributor
There was a problem hiding this comment.
I think this needs to be inside the For loop. Basically you want
// SELECT * FROM metadata_aspect WHERE urn = 'urn0' AND aspect = 'aspect0' AND version = 0 ORDER BY createdOn DESC limit 1
// UNION ALL
// SELECT * FROM metadata_aspect WHERE urn = 'urn0' AND aspect = 'aspect1' AND version = 0 ORDER BY createdOn DESC limit 1
does it make sense?
Contributor
Author
There was a problem hiding this comment.
I thought through this as well and believed it should be outside because in the case where you're running multiple SELECT's, we want the final result to be ordered, not just each subsection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
<fix> :added ordering to get() make sure that the most recent record (despite duplicates in other versioning) is at the top and returned<test> :added a unit test with corresponding SQL script to ensure that the above fix worksThe unit test requires a new script because the existing scripts would throw a Primary / Unique Key Error; a new script that adds
createdOnwas required.