Skip to content

fix: use MetadataAuditStamp instead of com.linkedin.common.AuditStamp#309

Open
jsdonn wants to merge 1 commit intolinkedin:masterfrom
jsdonn:audit
Open

fix: use MetadataAuditStamp instead of com.linkedin.common.AuditStamp#309
jsdonn wants to merge 1 commit intolinkedin:masterfrom
jsdonn:audit

Conversation

@jsdonn
Copy link
Copy Markdown
Contributor

@jsdonn jsdonn commented Oct 31, 2023

Saw some downstream errors complaining about namespace mismatch i.e.

com.linkedin.schemaregistry.validation.IncompatibleSchemaException: com.linkedin.schemaregistry.AvroSchemaRenameException: (suspected) attempt to rename nested RECORD com.linkedin.common.AuditStamp to com.linkedin.pegasus2avro.common.AuditStamp
At :MetadataAuditEvent:auditStamp:union

The reason is because the downstream (metadata-models) explicitly excludes core-models module, which com.linkedin.common.AuditStamp is a part of. So one solution to this is to define our own AuditStamp model and use that instead. To avoid confusion, renamed to MetadataAuditStamp.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant