Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
============================================
+ Coverage 64.56% 64.57% +0.01%
- Complexity 1657 1662 +5
============================================
Files 141 141
Lines 6555 6572 +17
Branches 801 805 +4
============================================
+ Hits 4232 4244 +12
- Misses 1978 1981 +3
- Partials 345 347 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces support for the HikariCP connection pool in the Ebean DAO implementation. The most significant changes are the addition of the HikariCP dependency and logic to handle HikariCP data sources when creating the schema evolution manager configuration.
Dependency management:
externalDependency.hikariCPto thedao-impl/ebean-dao/build.gradledependencies to enable HikariCP support.Schema evolution manager initialization:
EbeanLocalAccess.javato importHikariDataSourcefor type checking and extraction of connection details.createSchemaEvolutionManagermethod inEbeanLocalAccess.javato detect if the Ebean server is using a HikariCP data source and extract the JDBC URL, username, and password accordingly. Falls back to the existing logic if HikariCP is not used.Testing Done
./gradlew build
Checklist