Mock: Add multidimensional type class #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wescande
force-pushed
the
main
branch
2 times, most recently
from
ef27311 to
616a53d
Compare
drewhannay
reviewed
Feb 24, 2025
Contributor
drewhannay
left a comment
drewhannay
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing, just one question!
dexmaker-mockito-inline/src/main/java/com/android/dx/mockito/inline/MockMethodAdvice.java
Outdated
Show resolved
Hide resolved
While mocking native interface, it will fail with error such as: ``` Caused by: java.lang.ClassNotFoundException: Invalid name: [Lbyte[]; at java.lang.Class.classForName(Native Method) at java.lang.Class.forName(Class.java:597) at java.lang.Class.forName(Class.java:502) at com.android.dx.mockito.inline.MockMethodAdvice.getOrigin(MockMethodAdvice.java:166) ``` Indeed "[Lbyte[]" is not correct as the class is a "[[B". Adding entries in MockMethodAdvice to do the conversion with a non specified number of dimension for primitive and qualified type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While mocking native interface, it will fail with error such as:
Indeed "[Lbyte[]" is not correct as the class is a "[[B". Adding entries in MockMethodAdvice to do the conversion with a non specified number of dimension for primitive and qualified type
FYI: Opening request here as I initially made the contribution within android AOSP: https://r.android.com/3470136