Fix TestClusterMaintenanceMode Flaky Tests #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ngngwr
changed the title
kabragaurav
reviewed
Jan 5, 2026
...x-core/src/test/java/org/apache/helix/integration/controller/TestClusterMaintenanceMode.java
Outdated
Show resolved
Hide resolved
kabragaurav
reviewed
Jan 5, 2026
...x-core/src/test/java/org/apache/helix/integration/controller/TestClusterMaintenanceMode.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
NA
Description
The test failures started after the change introduced in
#43
.
With this change, IdealStateChange now triggers the External View pipeline, even when the cluster is in maintenance mode. As a result:
This PR updates the affected tests to align with the new behavior by validating the correct ExternalView state without expecting assignments during maintenance mode.
Tests
Fixes the TestClusterMaintenanceMode tests.