-
Notifications
You must be signed in to change notification settings - Fork 75
Introduce a separate GHA workflow for Pull Request Validation to validate the correct commit hashes #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Will-Lo
merged 11 commits into
linkedin:main
from
Will-Lo:fix-github-actions-commit-sha
Dec 17, 2024
+63
−36
Merged
Introduce a separate GHA workflow for Pull Request Validation to validate the correct commit hashes #269
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6448b1e
Change github actions to use the default checkout sha, the sha of the…
Will-Lo cea8b28
Add back fetch-depth 0 for tagging purposes
Will-Lo b064b71
Separate PR workflow from workflows running on main for better separa…
Will-Lo 4c201a3
Small optimizations to the pull request workflow
Will-Lo 75c92d8
Fix formatting
Will-Lo 1f4636a
Refactor workflow to use composite actions
Will-Lo 721b5dc
Fix naming
Will-Lo fca91b9
Remove unneeded workflow call composite action
Will-Lo 4383bf0
Use reuseable workflows instead of composite actions
Will-Lo d08cb12
Remove composite action reference
Will-Lo a0fa29c
Checkout in the build-and-run-tests
Will-Lo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| name: Gradle Build and Test Pull Requests to OpenHouse | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| branches: | ||
| - main | ||
|
|
||
| concurrency: | ||
| group: ci-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build-gradle-project: | ||
| name: Build Latest commit | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout project sources using merge commit hash | ||
| uses: actions/checkout@v4 | ||
Will-Lo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v1 | ||
| with: | ||
| distribution: 'microsoft' | ||
| java-version: '17' | ||
|
|
||
| - name: Validate Gradle Wrapper | ||
| uses: gradle/wrapper-validation-action@v1 | ||
|
|
||
| - name: Build with Gradle | ||
| run: ./gradlew clean build | ||
|
|
||
| - name: Start Docker Containers | ||
| run: docker compose -f infra/recipes/docker-compose/oh-only/docker-compose.yml up -d --build | ||
|
|
||
| - name: Wait for Docker Containers to start | ||
| run: sleep 30 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.x' | ||
|
|
||
| - name: Install dependencies | ||
| run: pip install -r scripts/python/requirements.txt | ||
|
|
||
| - name: Run Integration Tests | ||
| run: python scripts/python/integration_test.py ./tables-test-fixtures/tables-test-fixtures-iceberg-1.2/src/main/resources/dummy.token | ||
|
|
||
| - name: Stop Docker Containers | ||
| run: docker compose -f infra/recipes/docker-compose/oh-only/docker-compose.yml down | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.