Skip to content

Conversation

@alpeb
Copy link
Member

@alpeb alpeb commented Feb 17, 2025

This makes the logic introduced in #440 more robust, by watching over the proper file change to trigger the kubeconfig file re-creation. See linkerd/linkerd2#12573 (comment)

@alpeb alpeb requested a review from a team as a code owner February 17, 2025 01:42
Copy link
Member

@zaharidichev zaharidichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alpeb
Copy link
Member Author

alpeb commented Feb 20, 2025

@dependabot rebase

This makes the logic introduced in #440 more robust, by watching over
the proper file change to trigger the kubeconfig file re-creation.
See linkerd/linkerd2#12573 (comment)
@alpeb alpeb force-pushed the alpeb/sa-token-rotation-detection-fixup branch from 93f3d75 to 7166afe Compare February 20, 2025 15:47
@alpeb alpeb merged commit e76e1eb into main Feb 20, 2025
12 checks passed
@alpeb alpeb deleted the alpeb/sa-token-rotation-detection-fixup branch February 20, 2025 16:03
sdickhoven pushed a commit to sdickhoven/linkerd2-proxy-init that referenced this pull request Jun 11, 2025
* fix(linkerd-cni): improve SA token rotation detection

This makes the logic introduced in linkerd#440 more robust, by watching over
the proper file change to trigger the kubeconfig file re-creation.
See linkerd/linkerd2#12573 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants