build(validator): modify Ci job to release windows binaries #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaharidichev
force-pushed
the
zd/release-validator-win-binaries
branch
from
f3d8d5e to
f6bd56d
Compare
Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
force-pushed
the
zd/release-validator-win-binaries
branch
from
f6bd56d to
b075461
Compare
Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
changed the title
zaharidichev
commented
Jun 17, 2025
| build *flags: | ||
| {{ _cargo }} fetch --locked | ||
| {{ _cargo }} build --workspace -p {{ crate }} {{ flags }} | ||
| {{ _cargo }} build {{ if crate == "" { "--workspace" } else { "-p " + crate } }} {{ flags }} |
Member
Author
There was a problem hiding this comment.
We do that to avoid compiling the whole workspace when we are just targeting one of the repos. One of the problems that happens if this is not in place is that when we are compiling for Windows systems, we try to compile the CNI repair controller as well which has some dependencies that cannot be compiled for Windows, making the whole build job fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR augments the validator release action to also publish windows binaries.