Skip to content

Conversation

@cratelyn
Copy link
Member

@cratelyn cratelyn commented May 16, 2025

NB: supersedes #3918.

this addresses errors observed by dependabot when upgrading to the
latest version of markdownlint.

there is a new lint, added in DavidAnson/markdownlint#1459, that
introduces forbidden link text to discourage generic text in links.

this fixes sentences that included a link labeled "here".

 Summary: 3 error(s)
Error: docs/FUZZING.md:17:13 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md059.md
Error: docs/FUZZING.md:100:2 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md059.md
Error: README.md:90:2 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md059.md
Error: Failed with exit code: 1

Bumps DavidAnson/markdownlint-cli2-action from 19.1.0 to 20.0.0.


updated-dependencies:

  • dependency-name: DavidAnson/markdownlint-cli2-action
    dependency-version: 20.0.0
    dependency-type: direct:production
    update-type: version-update:semver-major
    ...

@cratelyn cratelyn marked this pull request as ready for review May 16, 2025 20:45
@cratelyn cratelyn requested a review from a team as a code owner May 16, 2025 20:45
@cratelyn cratelyn enabled auto-merge (squash) May 16, 2025 20:46
@cratelyn cratelyn disabled auto-merge May 16, 2025 20:46
@cratelyn cratelyn enabled auto-merge (rebase) May 16, 2025 20:46
@cratelyn cratelyn disabled auto-merge May 16, 2025 20:46
cratelyn and others added 2 commits May 16, 2025 16:46
this addresses errors observed by dependabot when upgrading to the
latest version of `markdownlint`.

there is a new lint, added in DavidAnson/markdownlint#1459, that
introduces forbidden link text to discourage generic `here` text in
links.

this fixes sentences that included a link labeled "here".

* #3918
* https://github.com/linkerd/linkerd2-proxy/actions/runs/15043224730/job/42279610780?pr=3918
* https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md059.md
* DavidAnson/markdownlint#1459
* DavidAnson/markdownlint#681

```
 Summary: 3 error(s)
Error: docs/FUZZING.md:17:13 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md059.md
Error: docs/FUZZING.md:100:2 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md059.md
Error: README.md:90:2 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"] https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md059.md
Error: Failed with exit code: 1
```

Signed-off-by: katelyn martin <[email protected]>
Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 19.1.0 to 20.0.0.
- [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases)
- [Commits](DavidAnson/markdownlint-cli2-action@05f3221...992badc)

---
updated-dependencies:
- dependency-name: DavidAnson/markdownlint-cli2-action
  dependency-version: 20.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@cratelyn cratelyn force-pushed the kate/markdown-lint-address-generic-link-text branch from 3e9f7b6 to 428d9f1 Compare May 16, 2025 20:47
@cratelyn cratelyn enabled auto-merge (rebase) May 16, 2025 20:49
@cratelyn cratelyn disabled auto-merge May 16, 2025 20:54
@cratelyn cratelyn enabled auto-merge (squash) May 16, 2025 20:55
@cratelyn cratelyn merged commit 478e1e1 into main May 22, 2025
18 checks passed
@cratelyn cratelyn deleted the kate/markdown-lint-address-generic-link-text branch May 22, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants