refactor(identity): move equality check into app#4430
Merged
Conversation
Signed-off-by: katelyn martin <kate@buoyant.io>
Signed-off-by: katelyn martin <kate@buoyant.io>
this addresses a long-standing todo comment in the linkerd-identity library. this moves a bit of validation logic that confirms, when running in the regular "Linkerd" mode, that the `id` field contains a DNS name, and that `server_name` matches it. Signed-off-by: katelyn martin <kate@buoyant.io>
Signed-off-by: katelyn martin <kate@buoyant.io>
Signed-off-by: katelyn martin <kate@buoyant.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(app/identity): TlsIdAndServerNameNotMatching is Clone
Signed-off-by: katelyn martin kate@buoyant.io
refactor(app/identity): EnvError: From
Signed-off-by: katelyn martin kate@buoyant.io
refactor(identity): move equality check into app
this addresses a long-standing todo comment in the linkerd-identity
library. this moves a bit of validation logic that confirms, when
running in the regular "Linkerd" mode, that the
idfield contains aDNS name, and that
server_namematches it.Signed-off-by: katelyn martin kate@buoyant.io
refactor(identity): EnvError::TlsIdAndServerNameNotMatching
Signed-off-by: katelyn martin kate@buoyant.io