viz: Prohibit authority resource targets in stat commands #13578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outbound Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
changed the title
Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
force-pushed
the
zd/no-authority
branch
from
68c3237 to
1ca4efc
Compare
adleong
reviewed
Jan 21, 2025
Member
adleong
left a comment
adleong
left a comment
There was a problem hiding this comment.
Now that we don't suppport authorities as a resource in any CLI commands, can we just remove authority from the list of resources in pkg/k8s/k8s.go ? that way it should stop being a supported resource without needing to special case it.
Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
smuth4
added a commit
to smuth4/linkerd2
that referenced
this pull request
Mar 22, 2025
PR linkerd#13578 removes 'authority' from being a pseudo-k8s resource, but the viz web `/tap` form still expects it to be present, issuing a `/api/tps-reports?resource_type=authority&all_namespaces=true` call, which returns 500 `cannot find Kubernetes canonical name from friendly name [authority]`, breaking the form entirely. This change removes all references to authorities in the form, restoring functionality. This was validated against a edge-25.3.1 linkerd-viz install by performing a successful tap with the new code. Signed-off-by: Stephen Muth <[email protected]>
smuth4
added a commit
to smuth4/linkerd2
that referenced
this pull request
Mar 22, 2025
PR linkerd#13578 removes 'authority' from being a pseudo-k8s resource, but the viz web `/tap` form still expects it to be present, issuing a `/api/tps-reports?resource_type=authority&all_namespaces=true` call, which returns 500 `cannot find Kubernetes canonical name from friendly name [authority]`, breaking the form entirely. This change removes all references to authorities in the form, restoring functionality. This was validated against a edge-25.3.3 linkerd/linkerd-viz install by performing a successful tap with the new code in the web UI. Fixes linkerd#13841 Signed-off-by: Stephen Muth <[email protected]>
olix0r
pushed a commit
that referenced
this pull request
Mar 24, 2025
PR #13578 removes 'authority' from being a pseudo-k8s resource, but the viz web `/tap` form still expects it to be present, issuing a `/api/tps-reports?resource_type=authority&all_namespaces=true` call, which returns 500 `cannot find Kubernetes canonical name from friendly name [authority]`, breaking the form entirely. This change removes all references to authorities in the form, restoring functionality. This was validated against a edge-25.3.3 linkerd/linkerd-viz install by performing a successful tap with the new code in the web UI. Fixes #13841 Signed-off-by: Stephen Muth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are plans to remove the authority label in inbound proxy metrics. When that happens we would not longer be able to use the viz stat/top commands to query by
authority. This is a change to disable being able to invoke these commands with anauthorityresource target.Signed-off-by: Zahari Dichev [email protected]