Skip to content

fix(service-mirror): don't restart cluster watch upon Link status updates #13579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alpeb merged 3 commits into from
Jan 22, 2025
Merged

fix(service-mirror): don't restart cluster watch upon Link status updates #13579

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b19102f
fix(service-mirror): don't restart cluster watch upon Link status upd…
alpeb Jan 20, 2025
d0f85c4
Lower log level
alpeb Jan 21, 2025
207bdf2
Extract the resource event handler functions into a separate file, an…
alpeb Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions multicluster/cmd/service-mirror/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"fmt"
"os"
"os/signal"
"reflect"
"syscall"
"time"

Expand Down Expand Up @@ -164,17 +165,26 @@ func Main(args []string) {
}
}
},
UpdateFunc: func(_, obj interface{}) {
link, ok := obj.(*v1alpha2.Link)
UpdateFunc: func(oldObj, currentObj interface{}) {
oldLink, ok := oldObj.(*v1alpha2.Link)
if !ok {
log.Errorf("object is not a Link: %+v", obj)
log.Errorf("object is not a Link: %+v", oldObj)
return
}
if link.GetName() == linkName {
currentLink, ok := currentObj.(*v1alpha2.Link)
if !ok {
log.Errorf("object is not a Link: %+v", currentObj)
return
}
if reflect.DeepEqual(oldLink.Spec, currentLink.Spec) {
log.Infof("Link update ignored (only status changed): %s", currentLink.GetName())
Comment thread
alpeb marked this conversation as resolved.
Outdated
return
}
if currentLink.GetName() == linkName {
select {
case results <- link:
case results <- currentLink:
Comment thread
olix0r marked this conversation as resolved.
Outdated
default:
log.Errorf("Link update dropped (queue full): %s", link.GetName())
log.Errorf("Link update dropped (queue full): %s", currentLink.GetName())
}
}
},
Expand Down