refactor(destination): consolidate Get stream lifecycle #14607
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
force-pushed
the
ver/chan-refactorio
branch
2 times, most recently
from
0077e90 to
a9b9d50
Compare
olix0r
changed the title
olix0r
force-pushed
the
ver/chan-refactorio
branch
8 times, most recently
from
3b392e1 to
c0498fa
Compare
olix0r
force-pushed
the
ver/test-fail
branch
2 times, most recently
from
23c3567 to
de64f43
Compare
olix0r
force-pushed
the
ver/chan-refactorio
branch
from
c0498fa to
89ccfa9
Compare
olix0r
force-pushed
the
ver/chan-refactorio
branch
from
89ccfa9 to
a615cf7
Compare
olix0r
force-pushed
the
ver/chan-refactorio
branch
from
a615cf7 to
72700f0
Compare
olix0r
force-pushed
the
ver/chan-refactorio
branch
from
72700f0 to
9f5c874
Compare
Get handlers leaked grpc stream control into translators, forcing extra goroutines and ad-hoc cancellation paths that were easy to mismanage. This change centralizes lifecycle ownership in server.go, moving translatorƒs/watchers to channel-based updates with shared context cancellation. It removes the synchronized stream wrapper to keep shutdown semantics consistent.
olix0r
force-pushed
the
ver/chan-refactorio
branch
from
9f5c874 to
bc898b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get handlers leaked grpc stream control into translators, forcing extra goroutines and ad-hoc cancellation paths that were easy to mismanage.
This change centralizes lifecycle ownership in server.go, moving translatorƒs/watchers to channel-based updates with shared context cancellation. It removes the synchronized stream wrapper to keep shutdown semantics consistent.