refactor(destination): use channel-based async messaging for endpoint updates #14628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updates This refactors the destination API's endpoint translator and federated service watcher to use a simpler channel-based architecture for sending updates to gRPC streams. Key changes: * Remove Start/Stop goroutine lifecycle management from endpoint translators - Translators no longer manage their own goroutines - Add mutex to protect concurrent access to address maps - Methods (Add/Remove/NoEndpoints) now directly modify state with locking * Simplify message flow in server.Get handler - Create single messages channel per stream in Get handler - Spawn goroutine to forward messages from channel to gRPC stream - Pass messages channel and resetStream function to translators - Remove StreamQueueCapacity parameter from translator constructors * Refactor federated service watcher - Remove synchronizedGetStream wrapper and its goroutine - Pass messages channel directly to all translators - Update Subscribe/Unsubscribe signatures to accept channels instead of streams - Simplify subscriber lifecycle management * Delete syncronized_get_stream.go (no longer needed) All tests pass with race detection enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.