fix(injector): improved support for native sidecar servers #14767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Extracted from #14566) This improves the injector logic by accounting for ports exposed in native sidecar containers: - when consuming the `config.linkerd.io/opaque-ports` annotations pointing to (named or integer) ports in init containers - when populating the proxy's `LINKERD2_PROXY_INBOUND_PORTS` env var The `webhook_tests.go` have been expanded to test injection to a pod with a memcached native sidecar container (never mind the contrivedness of the example).
alpeb
force-pushed
the
alpeb/nativesidecar-injection-issues
branch
2 times, most recently
from
a6c494c to
fd8a0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Extracted from #14566)
This improves the injector logic by accounting for ports exposed in native sidecar containers:
config.linkerd.io/opaque-portsannotations pointing to (named or integer) ports in init containersLINKERD2_PROXY_INBOUND_PORTSenv varThe
webhook_tests.gohave been expanded to test injection to a pod with a memcached native sidecar container (never mind the contrivedness of the example).