Skip to content

test(policy): address timeouts and flakiness #14773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+40 −16
Open

test(policy): address timeouts and flakiness #14773

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2b0124
test(policy): avoid timeouts due to flakiness
alpeb Dec 2, 2025
8f02571
before triggering watch, check if SA already exists
alpeb Dec 2, 2025
9c7a3c1
testing replacing initial SA check with sleep
alpeb Dec 3, 2025
aa37033
test adding ns watch
alpeb Dec 3, 2025
a95df41
refactor watches
alpeb Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion policy-test/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ where
.await;
tracing::trace!(?ns);
tokio::time::timeout(
tokio::time::Duration::from_secs(60),
tokio::time::Duration::from_secs(15),
await_service_account(&client, &ns.name_unchecked(), "default"),
)
.await
Expand Down Expand Up @@ -758,6 +758,17 @@ pub async fn await_service_account(client: &kube::Client, ns: &str, name: &str)
use futures::StreamExt;

tracing::trace!(%name, %ns, "Waiting for serviceaccount");

// First check if it already exists
if kube::Api::<k8s::ServiceAccount>::namespaced(client.clone(), ns)
.get(name)
.await
.is_ok()
{
return;
}
tracing::trace!("The serviceaccount does not yet exist; watching");

tokio::pin! {
let sas = kube::runtime::watcher(
kube::Api::<k8s::ServiceAccount>::namespaced(client.clone(), ns),
Expand Down