Set observedGeneration in status conditions#14973
Open
felipesere wants to merge 7 commits intolinkerd:mainfrom
Open
Set observedGeneration in status conditions#14973felipesere wants to merge 7 commits intolinkerd:mainfrom
observedGeneration in status conditions#14973felipesere wants to merge 7 commits intolinkerd:mainfrom
Conversation
Signed-off-by: Felipe Sere <felipe.sere@truelayer.com>
Signed-off-by: Felipe Sere <felipe.sere@truelayer.com>
Signed-off-by: Felipe Sere <felipe.sere@truelayer.com>
Signed-off-by: Felipe Sere <felipe.sere@truelayer.com>
Signed-off-by: Felipe Sere <felipe.sere@truelayer.com>
Member
|
👋 thanks for opening a pull request! it looks like the route_reattachment test is currently failing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other controllers and components of the k8s ecosystem (in this case Flagger) expect controllers that reconcile resources from the Gateway API to include their observed generate on the status conditions. This is also required by the spec
In this case, Flagger stalls the canary progress because it is not sure that Linkerd has reconciled and accepted the route.
Solution
Track the resource's
metadata.generationin RouteRef, HttpLocalRateLimitPolicyRef, and EgressNetworkRef structs. Thread this generation value through all condition-producing functions.Validation
All existing tests updated to pass generation through to condition constructors. Tests continue to pass with the new signatures
Fixes #14964
Signed-off-by: Felipe Seré felipe.sere@truelayer.com