Skip to content

Fix BiosaftyLevelEnum misspelling and remove unused imports from generated enums#22

Merged
cmungall merged 3 commits intonew-value-sets-octfrom
copilot/sub-pr-20-again
Nov 5, 2025
Merged

Fix BiosaftyLevelEnum misspelling and remove unused imports from generated enums#22
cmungall merged 3 commits intonew-value-sets-octfrom
copilot/sub-pr-20-again

Conversation

Copy link
Contributor

Copilot AI commented Nov 5, 2025

Addresses code review feedback from PR #20: enum name misspelling and unused type imports in generated Python files.

Changes

Fixed enum misspelling

  • BiosaftyLevelEnumBiosafetyLevelEnum in biosafety.yaml
  • Regenerated all affected Python files with correct spelling

Cleaned up generated imports

  • Updated modular_rich_generator.py to stop emitting unused Dict, Any, Optional imports
  • These types are only needed in the base RichEnum class, not in generated enum subclasses
  • Removed unused MagicMock import from test file

Before/After

# Before
from typing import Dict, Any, Optional
from valuesets.generators.rich_enum import RichEnum

class BiosaftyLevelEnum(RichEnum):
    BSL1 = "BSL1"
    # ...

# After
from valuesets.generators.rich_enum import RichEnum

class BiosafetyLevelEnum(RichEnum):
    BSL1 = "BSL1"
    # ...

Regenerated 108 Python enum files with corrected spelling and cleaner imports.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 5, 2025
Copilot AI and others added 2 commits November 5, 2025 18:06
Co-authored-by: cmungall <50745+cmungall@users.noreply.github.com>
Co-authored-by: cmungall <50745+cmungall@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 5, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.ror.org
    • Triggering command: /home/REDACTED/work/valuesets/valuesets/.venv/bin/python3 -m src.valuesets.validators.enum_evaluator src/valuesets/schema (dns block)
  • s3.amazonaws.com
    • Triggering command: /home/REDACTED/work/valuesets/valuesets/.venv/bin/python3 -m src.valuesets.validators.enum_evaluator src/valuesets/schema (dns block)
    • Triggering command: /home/REDACTED/work/valuesets/valuesets/.venv/bin/python3 -m pytest (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add organizations module with REST adapter architecture Fix BiosaftyLevelEnum misspelling and remove unused imports from generated enums Nov 5, 2025
Copilot AI requested a review from cmungall November 5, 2025 18:12
@cmungall cmungall marked this pull request as ready for review November 5, 2025 19:09
@cmungall cmungall merged commit fa15449 into new-value-sets-oct Nov 5, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants