Skip to content

Change markers to types (Issue #42) #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Change markers to types (Issue #42) #50

konard wants to merge 3 commits into from

Conversation

@konard
Copy link
Member

@konard konard commented Sep 12, 2025 •
edited
Loading

Summary

  • Updated XML documentation for the Type field to refer to it as 'root type' instead of 'meaning root'
  • This aligns with issue Change markers to types #42 requirements to clarify the type system naming conventions
  • The existing implementation already correctly follows the described type hierarchy pattern

Changes Made

  • Changed XML documentation comment from "The meaning root" to "The root type" in DefaultJsonStorage.cs:67

Type System Implementation

The current implementation already correctly implements the requested type system:

  • ✅ Root type: Type -> Type (line 281)
  • ✅ All other types follow pattern: (TypeName: Type -> TypeName) (lines 284-296)
  • ✅ Property names use "Type" suffix: ObjectType, StringType, ArrayType, etc.
  • ✅ No "marker" terminology found in codebase

Test Plan

  • All existing tests pass (51/51)
  • Build succeeds with only minor warnings unrelated to changes
  • Documentation updated to reflect proper terminology

🤖 Generated with Claude Code

Resolves #42

@konard
Initial commit with task details for issue #42
ad2488f 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #42
@konard konard self-assigned this Sep 12, 2025
@konard @claude
Update documentation to refer to Type as 'root type' instead of 'mean…
8d89307 
…ing root'

Changes made:
- Updated XML documentation for Type field to refer to it as 'root type' instead of 'meaning root'
- This aligns with the issue #42 requirement to clarify the type system naming conventions
- All tests pass and functionality remains unchanged

Closes #42

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Change markers to types Change markers to types (Issue #42) Sep 12, 2025
@konard konard marked this pull request as ready for review September 12, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change markers to types

2 participants

@konard