Skip to content

Rename IsUnusedLink() method to IsDeleted() #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rename IsUnusedLink() method to IsDeleted() #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcec17b
Initial commit with task details for issue #390
konard Sep 11, 2025
78f2134
Remove CLAUDE.md - PR created successfully
konard Sep 11, 2025
a73e291
Rename IsUnusedLink() method to IsDeleted()
konard Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/Platform.Data.Doublets/Memory/Split/Generic/SplitMemoryLinksBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ namespace Platform::Data::Doublets::Memory::Split::Generic
_indexMemory.UsedCapacity(_indexMemory.UsedCapacity() - LinkIndexPartSizeInBytes);
// Убираем все связи, находящиеся в списке свободных в конце файла, до тех пор, пока не дойдём до первой существующей связи
// Позволяет оптимизировать количество выделенных связей (AllocatedLinks)
while ((this->GetHeaderReference().AllocatedLinks > LinkAddressType{0}) && this->IsUnusedLink(this->GetHeaderReference().AllocatedLinks))
while ((this->GetHeaderReference().AllocatedLinks > LinkAddressType{0}) && this->IsDeleted(this->GetHeaderReference().AllocatedLinks))
{
UnusedLinksListMethods->Detach(this->GetHeaderReference().AllocatedLinks);
--this->GetHeaderReference().AllocatedLinks;
Expand All @@ -881,7 +881,7 @@ namespace Platform::Data::Doublets::Memory::Split::Generic
}

public:
bool IsUnusedLink(LinkAddressType linkIndex) const
bool IsDeleted(LinkAddressType linkIndex) const
{
if (GetHeaderReference().FirstFreeLink != linkIndex) // May be this check is not needed
{
Expand All @@ -900,7 +900,7 @@ namespace Platform::Data::Doublets::Memory::Split::Generic
{
return (linkAddress >= Constants.InternalReferencesRange.Minimum)
&& (linkAddress <= this->GetHeaderReference().AllocatedLinks)
&& !IsUnusedLink(linkAddress);
&& !IsDeleted(linkAddress);
}

public:
Expand Down
6 changes: 3 additions & 3 deletions cpp/Platform.Data.Doublets/Memory/United/Generic/UnitedMemoryLinksBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@
{
--header.AllocatedLinks;
_memory.UsedCapacity(_memory.UsedCapacity() - LinkSizeInBytes);
while ((header.AllocatedLinks > LinkAddressType {}) && IsUnusedLink(header.AllocatedLinks))
while ((header.AllocatedLinks > LinkAddressType {}) && IsDeleted(header.AllocatedLinks))
{
_UnusedLinksListMethods->Detach(header.AllocatedLinks);
--header.AllocatedLinks;
Expand Down Expand Up @@ -461,10 +461,10 @@
{
return false;
}
return (linkAddress >= Constants.InternalReferencesRange.Minimum) && (linkAddress <= this->GetHeaderReference().AllocatedLinks) && !IsUnusedLink(linkAddress);
return (linkAddress >= Constants.InternalReferencesRange.Minimum) && (linkAddress <= this->GetHeaderReference().AllocatedLinks) && !IsDeleted(linkAddress);
}

bool IsUnusedLink(LinkAddressType linkIndex) const
bool IsDeleted(LinkAddressType linkIndex) const
{
if (GetHeaderReference().FirstFreeLink != linkIndex)// May be this check is not needed
{
Expand Down
8 changes: 4 additions & 4 deletions csharp/Platform.Data.Doublets/Memory/Split/Generic/SplitMemoryLinksBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ public virtual TLinkAddress Delete(IList<TLinkAddress>? restriction, WriteHandle
_indexMemory.UsedCapacity -= LinkIndexPartSizeInBytes;
// Убираем все связи, находящиеся в списке свободных в конце файла, до тех пор, пока не дойдём до первой существующей связи
// Позволяет оптимизировать количество выделенных связей (AllocatedLinks)
while ((header.AllocatedLinks > GetZero()) && IsUnusedLink(linkIndex: header.AllocatedLinks))
while ((header.AllocatedLinks > GetZero()) && IsDeleted(linkIndex: header.AllocatedLinks))
{
UnusedLinksListMethods.Detach(freeLink: header.AllocatedLinks);
header.AllocatedLinks = header.AllocatedLinks - TLinkAddress.One;
Expand Down Expand Up @@ -942,12 +942,12 @@ protected virtual void ResetPointers()
[MethodImpl(methodImplOptions: MethodImplOptions.AggressiveInlining)]
protected virtual bool Exists(TLinkAddress link)
{
return (link >= Constants.InternalReferencesRange.Minimum) && (link <= GetHeaderReference().AllocatedLinks) && !IsUnusedLink(linkIndex: link);
return (link >= Constants.InternalReferencesRange.Minimum) && (link <= GetHeaderReference().AllocatedLinks) && !IsDeleted(linkIndex: link);
}

/// <summary>
/// <para>
/// Determines whether this instance is unused link.
/// Determines whether this instance is deleted.
/// </para>
/// <para></para>
/// </summary>
Expand All @@ -960,7 +960,7 @@ protected virtual bool Exists(TLinkAddress link)
/// <para></para>
/// </returns>
[MethodImpl(methodImplOptions: MethodImplOptions.AggressiveInlining)]
protected virtual bool IsUnusedLink(TLinkAddress linkIndex)
protected virtual bool IsDeleted(TLinkAddress linkIndex)
{
if ((GetHeaderReference().FirstFreeLink != linkIndex)) // May be this check is not needed
{
Expand Down
8 changes: 4 additions & 4 deletions csharp/Platform.Data.Doublets/Memory/United/Generic/UnitedMemoryLinksBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ public virtual TLinkAddress Delete(IList<TLinkAddress>? restriction, WriteHandle
_memory.UsedCapacity -= LinkSizeInBytes;
// Убираем все связи, находящиеся в списке свободных в конце файла, до тех пор, пока не дойдём до первой существующей связи
// Позволяет оптимизировать количество выделенных связей (AllocatedLinks)
while (GreaterThan(header.AllocatedLinks, GetZero()) && IsUnusedLink(header.AllocatedLinks))
while (GreaterThan(header.AllocatedLinks, GetZero()) && IsDeleted(header.AllocatedLinks))
{
UnusedLinksListMethods.Detach(header.AllocatedLinks);
header.AllocatedLinks = header.AllocatedLinks - TLinkAddress.One;
Expand Down Expand Up @@ -666,11 +666,11 @@ protected virtual void ResetPointers()
protected virtual bool Exists(TLinkAddress link)
=> GreaterOrEqualThan(link, Constants.InternalReferencesRange.Minimum)
&& LessOrEqualThan(link, GetHeaderReference().AllocatedLinks)
&& !IsUnusedLink(link);
&& !IsDeleted(link);

/// <summary>
/// <para>
/// Determines whether this instance is unused link.
/// Determines whether this instance is deleted.
/// </para>
/// <para></para>
/// </summary>
Expand All @@ -683,7 +683,7 @@ protected virtual bool Exists(TLinkAddress link)
/// <para></para>
/// </returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected virtual bool IsUnusedLink(TLinkAddress linkIndex)
protected virtual bool IsDeleted(TLinkAddress linkIndex)
{
if (!AreEqual(GetHeaderReference().FirstFreeLink, linkIndex)) // May be this check is not needed
{
Expand Down
Loading