Remove conditional compilation for .NET Framework#96
Open
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #28
Removed the #if NET472 conditional compilation directives that were using string.Join() for .NET Framework and simplified to use Path.Combine() for all target frameworks. Also updated the test runner to use net8 instead of net7. This resolves issue #28 by eliminating the special case for .NET Framework since the project now only targets .NET 8. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#if NET472conditional compilation directives that were usingstring.Join()for .NET Framework 4.7.2Path.Combine()for all target frameworks since both projects now only target .NET 8Test plan
Path.Combine()This resolves issue #28 by eliminating the special case for .NET Framework.
🤖 Generated with Claude Code
Resolves #28