Implement internationalization of exception messages#99
Open
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #9
- Add Resources.resx and Resources.ru.resx for English and Russian localization - Create strongly-typed Resources.Designer.cs for accessing localized strings - Update DisposableBase.cs to use localized exception message for multiple dispose calls - Add comprehensive unit test for verifying internationalization works across cultures - Fix test framework reference from net7 to net8 to resolve DisposalOrderTest failure 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements internationalization (i18n) for exception messages in the Platform.Disposables library to support multiple languages.
Changes Made
Created resource files:
Resources.resx- Default English exception messagesResources.ru.resx- Russian translationResources.Designer.cs- Strongly-typed resource access classUpdated DisposableBase.cs:
Resources.MultipleDisposeCallsNotAllowedfor culture-specific messagesAdded comprehensive test:
MultipleDisposeExceptionMessageInternationalizationTestverifies proper localizationCultureInfo.CurrentUICultureFixed existing test:
DisposalOrderTestfrom net7 to net8 framework referenceTechnical Details
The implementation follows standard .NET resource file patterns:
Resourcesclass provides compile-time safetyTesting
All tests pass, including the new internationalization test that verifies:
🤖 Generated with Claude Code
Resolves #9