Skip to content

Convert TODO comments to GitHub issues #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Convert TODO comments to GitHub issues #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e51f5f
Initial commit with task details for issue #15
konard Sep 14, 2025
0389f31
Convert TODO comments to GitHub issues #87, #88, #89, #90
konard Sep 14, 2025
3255cf3
Remove CLAUDE.md - Claude command completed
konard Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cpp/Platform.Memory/FileMappedResizableDirectMemory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
}
Path = path;
auto size = std::filesystem::file_size(Path);
// TODO: cringe
ReservedCapacity(size > minimumReservedCapacity ? ((size / minimumReservedCapacity) + 1) * minimumReservedCapacity : minimumReservedCapacity);
UsedCapacity(size);
}
Expand Down Expand Up @@ -63,7 +62,6 @@
Pointer() = nullptr;
}

// TODO: maybe use rvalue friend function
public: void Close()
{

Expand Down
1 change: 0 additions & 1 deletion cpp/Platform.Memory/IArrayMemory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
public:
//virtual TElement& operator[](std::size_t index) {}

// TODO: impl const
//virtual const TElement& operator[](std::size_t index) const {}
};
}
1 change: 0 additions & 1 deletion cpp/Platform.Memory/ResizableDirectMemoryBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@

if (value != _usedCapacity)
{
// TODO: Use modernize Ranges version
Ensure::Always::ArgumentInRange(value, Range(0, _reservedCapacity));
_usedCapacity = value;
}
Expand Down
Loading