Conversation
adamgreg
force-pushed
the
locator-children
branch
2 times, most recently
from
089f7ee to
df5de2b
Compare
| // deno-lint-ignore no-import-prefix | ||
| import type { PageProps } from "https://deno.land/x/pyro@0.6.1/page.ts"; | ||
| import { ensureFileSync } from "https://deno.land/std@0.215.0/fs/ensure_file.ts"; | ||
| import { ensureFileSync } from "@std/fs/ensure-file"; |
There was a problem hiding this comment.
question: is this change necessary for this PR?
There was a problem hiding this comment.
The lint check fails for both of those direct https imports, so CI won't pass. You already have the JSR @std/fs in the import map, so I thought this must just be legacy. Couldn't find Pyro on JSR, so just ignored that one.
Would be happy to handle it differently!
There was a problem hiding this comment.
Ah I see, new deno lints are stricter. Could you instead have the linter ignore the entire docs folder? It's getting rewritten by a friend of mine anyways.
There was a problem hiding this comment.
ok, that's done. The linter will now completely ignore the docs folder.
There was a problem hiding this comment.
The commit to update the import from https://deno.land/std is still in there, but we can drop it if you prefer @lino-levan
tests/locator_test.ts
Outdated
| await using browser = await launch(); | ||
| await using page = await browser.newPage(server.address); | ||
| const targetLocator = page.locator<HTMLDivElement>("#target"); | ||
| await page.waitForNetworkIdle(); |
There was a problem hiding this comment.
question: Why is this wait for network idle necessary?
There was a problem hiding this comment.
It might not be! This is all new to me. I can remove it tomorrow morning
adamgreg
force-pushed
the
locator-children
branch
from
df5de2b to
970193a
Compare
|
HTTP Interceptor test failures on Windows seem unrelated and either new or intermittent? |
|
There is some rare flakiness in some of the tests, better than it used to be but it's definitely not perfect. |
2 participants
I would find it useful to be able to access descendants from a Locator. This PR adds methods to help with that.