fix: Take page scroll into account in ElementHandle.screenshot()#172
Merged
lino-levan merged 1 commit intolino-levan:mainfrom Oct 3, 2025
Merged
fix: Take page scroll into account in ElementHandle.screenshot()#172lino-levan merged 1 commit intolino-levan:mainfrom
lino-levan merged 1 commit intolino-levan:mainfrom
Conversation
Contributor
Author
|
Related: chromedp/chromedp#844 |
Owner
|
Can we merge master in to fix CI? |
adamgreg
force-pushed
the
fix-el-screenshot
branch
from
c3e9d92 to
e0d6d3c
Compare
lino-levan
approved these changes
Oct 3, 2025
Owner
lino-levan
left a comment
lino-levan
left a comment
There was a problem hiding this comment.
I assume you've tested this and it fixes the bug, wish we could have a test here but happy to merge once you confirm that this does actually resolve the issue.
Contributor
Author
It does fix it, at least in the case where the |
Owner
|
Sounds good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found that the clipping in ElementHandle.screenshot() is incorrect if the page has been scrolled, including if it was scrolled to make the element visible for the screenshot.
The co-ordinates in the element's box model are changed after scrolling, but the screenshot clip argument needs the original values.