Skip to content

When creating dynamic inventory, jinja-expand tags, regions, and types. #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brad2014 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

When creating dynamic inventory, jinja-expand tags, regions, and types. #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions plugins/inventory/instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,16 @@ def _get_query_options(
self, config_data: Dict[str, Any]
) -> Tuple[Any, Any, Any]:
"""Get user specified query options from the configuration."""

def expand_templates(query_list: List[str]) -> List[str]:
items = []
for item in query_list:
if self.templar.is_template(item):
items.append(self.templar.template(item, disable_lookups=False))
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting disable_lookups=False explicitly when it may already be the default could be misleading. Verify if this parameter needs to be specified, and if so, add a comment explaining why lookups should be enabled for these templates.

Suggested change
items.append(self.templar.template(item, disable_lookups=False))
items.append(
self.templar.template(
item,
# Intentionally enable lookups so inventory query
# values can use Ansible lookup plugins (for example,
# to pull regions/types/tags from external sources).
disable_lookups=False,
)
)

Copilot uses AI. Check for mistakes.
else:
items.append(item)
return items
Comment on lines +247 to +253
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expand_templates function can be simplified using a list comprehension to improve readability and reduce boilerplate code.

Suggested change
items = []
for item in query_list:
if self.templar.is_template(item):
items.append(self.templar.template(item, disable_lookups=False))
else:
items.append(item)
return items
return [
self.templar.template(item, disable_lookups=False)
if self.templar.is_template(item)
else item
for item in query_list
]

Copilot uses AI. Check for mistakes.

options = {
"regions": {
"type_to_be": list,
Expand All @@ -259,9 +269,9 @@ def _get_query_options(
name, options[name]["type_to_be"], options[name]["value"]
)

regions = options["regions"]["value"]
types = options["types"]["value"]
tags = options["tags"]["value"]
regions = expand_templates(options["regions"]["value"])
types = expand_templates(options["types"]["value"])
tags = expand_templates(options["tags"]["value"])

return regions, types, tags

Expand Down