Skip to content

TPT-4218: Update test and docs for ACLP alert channels#767

Open
yec-akamai wants to merge 3 commits intolinode:devfrom
yec-akamai:TPT-4218/alert-channels-update
Open

TPT-4218: Update test and docs for ACLP alert channels#767
yec-akamai wants to merge 3 commits intolinode:devfrom
yec-akamai:TPT-4218/alert-channels-update

Conversation

@yec-akamai
Copy link
Contributor

📝 Description

Reflect API update in response struct and update the docs. Add test cases for ACLP alert channels.

✔️ How to Test

make test-int TEST_SUITE=monitor_services_alert_channel_list 

@yec-akamai yec-akamai requested a review from a team as a code owner March 12, 2026 19:56
@yec-akamai yec-akamai requested review from lgarber-akamai and zliang-akamai and removed request for a team March 12, 2026 19:56
@yec-akamai yec-akamai added the testing for updates to the testing suite in the changelog. label Mar 12, 2026
@yec-akamai yec-akamai changed the title Update test and docs for ACLP alert channels TPT-4218: Update test and docs for ACLP alert channels Mar 12, 2026
@zliang-akamai zliang-akamai requested a review from Copilot March 18, 2026 04:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Monitor Alert Channel list module’s integration coverage and documentation examples to reflect the updated API response shape for ACLP alert channels.

Changes:

  • Added an integration test target for listing alert channels and filtering by label.
  • Updated doc fragment sample response for monitor_alert_channel_list to match the new API response structure (notably alerts).
  • Updated module documentation sample response accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/integration/targets/monitor_services_alert_channel_list/tasks/main.yaml Adds integration coverage for listing and filtering Monitor alert channels.
plugins/module_utils/doc_fragments/alert_channels_list.py Updates the doc fragment sample response structure for alert channel listing.
docs/modules/monitor_alert_channel_list.md Updates the rendered module docs sample response to match the new structure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the monitor_alert_channel_list module documentation/examples and adds an integration test suite to reflect the updated ACLP alert channel response structure.

Changes:

  • Added an integration test target to validate listing alert channels and filtering by a known system channel label.
  • Updated alert channel sample responses in doc fragments and generated module docs to match the updated API response shape (alerts summary object, details, etc.).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/integration/targets/monitor_services_alert_channel_list/tasks/main.yaml Adds integration coverage for alert channel list + filter behavior.
plugins/module_utils/doc_fragments/alert_channels_list.py Updates sample response structure used by module docs.
docs/modules/monitor_alert_channel_list.md Updates rendered documentation sample response to match API changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants