TPT-4218: Update test and docs for ACLP alert channels#767
TPT-4218: Update test and docs for ACLP alert channels#767yec-akamai wants to merge 3 commits intolinode:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Monitor Alert Channel list module’s integration coverage and documentation examples to reflect the updated API response shape for ACLP alert channels.
Changes:
- Added an integration test target for listing alert channels and filtering by label.
- Updated doc fragment sample response for
monitor_alert_channel_listto match the new API response structure (notablyalerts). - Updated module documentation sample response accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/integration/targets/monitor_services_alert_channel_list/tasks/main.yaml | Adds integration coverage for listing and filtering Monitor alert channels. |
| plugins/module_utils/doc_fragments/alert_channels_list.py | Updates the doc fragment sample response structure for alert channel listing. |
| docs/modules/monitor_alert_channel_list.md | Updates the rendered module docs sample response to match the new structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
tests/integration/targets/monitor_services_alert_channel_list/tasks/main.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Updates the monitor_alert_channel_list module documentation/examples and adds an integration test suite to reflect the updated ACLP alert channel response structure.
Changes:
- Added an integration test target to validate listing alert channels and filtering by a known system channel label.
- Updated alert channel sample responses in doc fragments and generated module docs to match the updated API response shape (
alertssummary object,details, etc.).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/integration/targets/monitor_services_alert_channel_list/tasks/main.yaml | Adds integration coverage for alert channel list + filter behavior. |
| plugins/module_utils/doc_fragments/alert_channels_list.py | Updates sample response structure used by module docs. |
| docs/modules/monitor_alert_channel_list.md | Updates rendered documentation sample response to match API changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 Description
Reflect API update in response struct and update the docs. Add test cases for ACLP alert channels.
✔️ How to Test