Skip to content

feat: updated tty rolebinding #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ani1357 merged 2 commits into from
Nov 26, 2024
Merged

feat: updated tty rolebinding #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd4f8b
feat: updated tty rolebinding
Ani1357 Nov 19, 2024
3a58095
feat: updated logout redirect_uri
Ani1357 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/k8s_operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export async function k8sdelete({ emailNoSymbols, isAdmin, userTeams }: Cloudtty
await k8sApi.deleteNamespacedPod(`tty-${resourceName}`, namespace)
if (!isAdmin) {
for (const team of userTeams!)
await rbacAuthorizationV1Api.deleteNamespacedRoleBinding(`tty-${team}-rolebinding`, team)
await rbacAuthorizationV1Api.deleteNamespacedRoleBinding(`tty-${team}-${resourceName}-rolebinding`, team)
} else await rbacAuthorizationV1Api.deleteClusterRoleBinding('tty-admin-clusterrolebinding')
await k8sApi.deleteNamespacedService(`tty-${resourceName}`, namespace)

Expand Down
2 changes: 1 addition & 1 deletion src/ttyManifests/adminTtyManifests/tty_05_Vs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
prefix: /logout-otomi
redirect:
authority: auth.$FQDN
uri: /oauth2/sign_out?rd=https://keycloak.$FQDN/realms/otomi/protocol/openid-connect/logout?redirect_uri=https://otomi.$FQDN
uri: /oauth2/sign_out?rd=https://keycloak.$FQDN/realms/otomi/protocol/openid-connect/logout?redirect_uri=https://console.$FQDN
- match:
- uri:
prefix: /$EMAIL
Expand Down
2 changes: 1 addition & 1 deletion src/ttyManifests/tty_03_Rolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: tty-$TARGET_TEAM-rolebinding
name: tty-$TARGET_TEAM-$EMAIL-rolebinding
namespace: $TARGET_TEAM
roleRef:
apiGroup: rbac.authorization.k8s.io
Expand Down
2 changes: 1 addition & 1 deletion src/ttyManifests/tty_05_Vs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
prefix: /logout-otomi
redirect:
authority: auth.$FQDN
uri: /oauth2/sign_out?rd=https://keycloak.$FQDN/realms/otomi/protocol/openid-connect/logout?redirect_uri=https://otomi.$FQDN
uri: /oauth2/sign_out?rd=https://keycloak.$FQDN/realms/otomi/protocol/openid-connect/logout?redirect_uri=https://console.$FQDN
- match:
- uri:
prefix: /$EMAIL
Expand Down