Skip to content

fix: workaround for team id needed in console #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CasLubbers merged 3 commits into from
Apr 14, 2025
Merged

fix: workaround for team id needed in console #692

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92c6c3d
fix: workaround for team id needed in console
merll Apr 11, 2025
cdcacf2
Merge branch 'main' into APL-706-followup
merll Apr 11, 2025
8f5855d
fix: set name instead of id
merll Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@ export async function loadFileToSpec(
return
}
}
// TODO: Remove workaround for User currently relying on id in console
if (fileMap.kind === 'AplUser') {
data.spec.id = data.metadata?.name
}
Expand All @@ -507,6 +508,10 @@ export async function loadFileToSpec(
}
} else {
const ref: Record<string, any> = get(spec, jsonPath)
// TODO: Remove workaround for Team settings currently relying on id in console
if (fileMap.kind === 'AplTeamSettingSet') {
data.spec.name = data.metadata?.name
}
// Decrypted secrets may need to be merged with plain text specs
const newRef = merge(cloneDeep(ref), data?.spec)
set(spec, jsonPath, newRef)
Expand Down
Loading