Skip to content

fix: change error thrown when authorize is not valid #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElderMatt merged 2 commits into from
May 6, 2025
Merged

fix: change error thrown when authorize is not valid #715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b724db
fix: change error thrown when authorize is not valid
ElderMatt May 2, 2025
fac6234
fix: combine if statements
ElderMatt May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/middleware/authz.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { RequestHandler } from 'express'
import { find } from 'lodash'
import get from 'lodash/get'
import Authz, { getTeamSelfServiceAuthz } from 'src/authz'
import { HttpError } from 'src/error'
import { OpenApiRequestExt } from 'src/otomi-models'
import OtomiStack from 'src/otomi-stack'
import { cleanEnv } from 'src/validators'
Expand Down Expand Up @@ -61,12 +62,8 @@ export function authorize(req: OpenApiRequestExt, res, next, authz: Authz, repoS
else valid = authz.validateWithCasl(action, schemaName, teamId)
const env = cleanEnv({})
// TODO: Debug purpose only for removal of license
if (!env.isDev) {
if (!valid) {
return res
.status(403)
.send({ authz: false, message: `User not allowed to perform "${action}" on "${schemaName}" resource` })
}
if (!env.isDev && !valid) {
throw new HttpError(403, `User not allowed to perform "${action}" on "${schemaName}" resource`)
}

const schemaToRepoMap: Record<string, string> = {
Expand Down
Loading