fix: labels and finalizers optional #722
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success289 tests passing in 12 suites. Report generated by 🧪jest coverage report action from 1d73ce7 |
ferruhcihan
reviewed
May 13, 2025
| labels: valueArrayToObject(data.metadata?.labels), | ||
| finalizers: data.metadata?.finalizers, | ||
| ...((data.metadata?.labels?.length ?? 0) > 0 && { | ||
| labels: valueArrayToObject(data.metadata?.labels), |
Collaborator
There was a problem hiding this comment.
Looks like these fields are already removed here (if they're empty), this might be a duplicate removal.
Contributor
Author
|
This issue does not seem to be present anymore on dev-cluster. It seems we already have a removal in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only fills in labels and finalizers if they are being added.