Skip to content

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Nov 26, 2024

Implements

https://jira.linode.com/browse/APL-305

Description

This PR fixes the user management team view to assign user to team-admin and enable/disable the update users button.
Is paired with: linode/apl-api#590

Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with Jeho and feature is working as it should. Naming is just a bit confusing. As you now can assign someone as a admin for a team. And you have the team-admin

Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ani1357 Ani1357 self-requested a review November 28, 2024 08:33
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested on a cluster running APL v4.1.1. Updated api and core to APL-305.
  • Created a new team (demo) and user ([email protected])
  • Checked the team-admin checkbox in the "team" view of team-admin
    image
  • When I go back to the platform's "User Management" and try to check the "Is team admin" checkbox I get en error in console if I click "Submit"
    image
    image

@dennisvankekem dennisvankekem removed their assignment Nov 28, 2024
@ElderMatt
Copy link
Contributor

Strange that the bug is back, because is has already been fixed once before.

@dennisvankekem
Copy link
Collaborator

closed. see: #484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants