feat: remove deploy and revert changes buttons#493
Merged
ferruhcihan merged 7 commits intomainfrom Jan 16, 2025
Merged
Conversation
Collaborator
|
Code looks clean |
ElderMatt
approved these changes
Jan 10, 2025
Contributor
|
Tested and it works but adding something is pretty slow... If you are a bit impatient and click to other pages it looks a bit weird. We could maybe add an loading thing on the whole page so you don't go to other pages. |
CasLubbers
approved these changes
Jan 15, 2025
Contributor
Good point. We should block user actions on page until there is a response from server |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
https://jira.linode.com/browse/APL-241
Description
This PR removes the deploy and revert changes buttons and updates the session provider to improve snack notification messages.
Is paired with: linode/apl-api#608