Skip to content

feat: Upgrade React v18.3.1 and RJSF v5.24.2#504

Merged
dennisvankekem merged 6 commits intomainfrom
APL-514
Feb 7, 2025
Merged

feat: Upgrade React v18.3.1 and RJSF v5.24.2#504
dennisvankekem merged 6 commits intomainfrom
APL-514

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Feb 5, 2025

Implements

https://jira.linode.com/browse/APL-514
https://rjsf-team.github.io/react-jsonschema-form/docs/migration-guides/v5.x%20upgrade%20guide
https://react.dev/blog/2022/03/08/react-18-upgrade-guide

Description

This PR upgrades React from v17 to v18, RJSF from v4 to v5, and also updates other related dependencies due to the React version upgrade, removes unnecessary files and dependencies.
Please check this => https://jira.linode.com/browse/APL-514?focusedId=555666&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-555666

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@ferruhcihan ferruhcihan changed the title Apl 514 feat: Upgrade React v18.3.1 and RJSF v5.24.2 Feb 5, 2025
@dennisvankekem dennisvankekem self-assigned this Feb 6, 2025
@dennisvankekem
Copy link
Collaborator

regarding "I have tested expected error states and verified that the user is presented with informative error messages.". React router dom is throwing some errors in the console and definitely should be updated later to remove those errors in the logs. But for now it's not a blocker

Copy link
Collaborator

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested against all the considerations, only one question regarding ArrayField removal

@ElderMatt ElderMatt self-assigned this Feb 6, 2025
Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested in multiple browsers. I tried looking into the types that were changed to any, but in a short time I was unable to fix it. It is something that can be looked at In the future.

@dennisvankekem dennisvankekem merged commit 2804b4d into main Feb 7, 2025
2 checks passed
@dennisvankekem dennisvankekem deleted the APL-514 branch February 7, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants