feat: Upgrade React v18.3.1 and RJSF v5.24.2#504
Merged
dennisvankekem merged 6 commits intomainfrom Feb 7, 2025
Merged
Conversation
Collaborator
|
regarding "I have tested expected error states and verified that the user is presented with informative error messages.". React router dom is throwing some errors in the console and definitely should be updated later to remove those errors in the logs. But for now it's not a blocker |
Collaborator
dennisvankekem
left a comment
There was a problem hiding this comment.
LGTM, tested against all the considerations, only one question regarding ArrayField removal
ElderMatt
approved these changes
Feb 6, 2025
Contributor
ElderMatt
left a comment
There was a problem hiding this comment.
LGTM, I tested in multiple browsers. I tried looking into the types that were changed to any, but in a short time I was unable to fix it. It is something that can be looked at In the future.
dennisvankekem
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
https://jira.linode.com/browse/APL-514
https://rjsf-team.github.io/react-jsonschema-form/docs/migration-guides/v5.x%20upgrade%20guide
https://react.dev/blog/2022/03/08/react-18-upgrade-guide
Description
This PR upgrades React from v17 to v18, RJSF from v4 to v5, and also updates other related dependencies due to the React version upgrade, removes unnecessary files and dependencies.
Please check this => https://jira.linode.com/browse/APL-514?focusedId=555666&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-555666
Considerations