Skip to content

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Apr 1, 2025

Implements

https://jira.linode.com/browse/APL-535
https://docs.google.com/document/d/1xAtM88sVC7VXAskz413Ec5AYVR7RDJoCcSZAaHYXZV0/edit?tab=t.0
https://www.figma.com/design/YuBiIolysFdtQgFEfAIJd1/APL-Master-Design?node-id=0-1&p=f&t=HFl0TjPGZV14lcGW-0

Description

This PR adds a new build page using the new form components, along with the new code repositories page.
Is paired with: linode/apl-api#678 and linode/apl-core#2026

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@dennisvankekem dennisvankekem self-assigned this Apr 2, 2025
@dennisvankekem
Copy link
Collaborator

image

why does the button have white text and why is the padding vertical lower than other buttons?

@dennisvankekem
Copy link
Collaborator

https://www.figma.com/design/loi1wLMJvpyeOlCcMCavn2/APL-535?node-id=0-1&p=f&t=FyizHcucO53TZllF-0 I've pointed out some design changes that needs to be adjusted, please have a look.

@dennisvankekem
Copy link
Collaborator

image

As the tag gets autofilled based on best effort, shouldn't we fill it in .toLowercase() by default and have the error text helper text there by default?

@dennisvankekem
Copy link
Collaborator

image

trying creating a build that already exists will throw an error

@ElderMatt
Copy link
Contributor

I think it would be nicer if the background does not go past the red line, perhaps we should place the add buttons a bit more to the right.
image

@ferruhcihan
Copy link
Collaborator Author

why does the button have white text and why is the padding vertical lower than other buttons?

Fixed!

@ferruhcihan
Copy link
Collaborator Author

https://www.figma.com/design/loi1wLMJvpyeOlCcMCavn2/APL-535?node-id=0-1&p=f&t=FyizHcucO53TZllF-0 I've pointed out some design changes that needs to be adjusted, please have a look.

Updated!

@ferruhcihan
Copy link
Collaborator Author

As the tag gets autofilled based on best effort, shouldn't we fill it in .toLowercase() by default and have the error text helper text there by default?

Updated.

@ferruhcihan
Copy link
Collaborator Author

trying creating a build that already exists will throw an error

Updated and yup validation improved.

@ferruhcihan
Copy link
Collaborator Author

I think it would be nicer if the background does not go past the red line, perhaps we should place the add buttons a bit more to the right.

Updated in the key-value component.

@ElderMatt
Copy link
Contributor

When going back to edit a container image. the checkbox for create webhook listener is gone.

Creating:
image

Editing:
image

@j-zimnowoda j-zimnowoda requested a review from Copilot April 10, 2025 15:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 26 out of 27 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • public/i18n/en/common.json: Language not supported
Comments suppressed due to low confidence (1)

src/pages/code-repositories/create-edit/create-edit.validator.ts:13

  • Ensure that codeRepoUrls is defined as an array before calling .some to avoid potential runtime errors if it is undefined. Consider using a default value such as an empty array.
const { codeRepoUrls, validateOnSubmit } = this.options.context || {}

@ElderMatt ElderMatt self-assigned this Apr 11, 2025
Copy link
Collaborator

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two questions but not blocking by any means, approved!

@dennisvankekem dennisvankekem merged commit ae2ae8a into main Apr 11, 2025
2 checks passed
@dennisvankekem dennisvankekem deleted the APL-535 branch April 11, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants