-
Notifications
You must be signed in to change notification settings - Fork 3
feat: build page using new form components #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
https://www.figma.com/design/loi1wLMJvpyeOlCcMCavn2/APL-535?node-id=0-1&p=f&t=FyizHcucO53TZllF-0 I've pointed out some design changes that needs to be adjusted, please have a look. |
Fixed! |
Updated! |
Updated. |
Updated and yup validation improved. |
Updated in the key-value component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 26 out of 27 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- public/i18n/en/common.json: Language not supported
Comments suppressed due to low confidence (1)
src/pages/code-repositories/create-edit/create-edit.validator.ts:13
- Ensure that codeRepoUrls is defined as an array before calling .some to avoid potential runtime errors if it is undefined. Consider using a default value such as an empty array.
const { codeRepoUrls, validateOnSubmit } = this.options.context || {}
dennisvankekem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two questions but not blocking by any means, approved!






Implements
https://jira.linode.com/browse/APL-535
https://docs.google.com/document/d/1xAtM88sVC7VXAskz413Ec5AYVR7RDJoCcSZAaHYXZV0/edit?tab=t.0
https://www.figma.com/design/YuBiIolysFdtQgFEfAIJd1/APL-Master-Design?node-id=0-1&p=f&t=HFl0TjPGZV14lcGW-0
Description
This PR adds a new build page using the new form components, along with the new code repositories page.
Is paired with: linode/apl-api#678 and linode/apl-core#2026
Considerations