Skip to content

fix: navconfig permission function #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ferruhcihan merged 2 commits into from
May 13, 2025
Merged

fix: navconfig permission function #555

ferruhcihan merged 2 commits into from
May 13, 2025

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented May 9, 2025 •
edited
Loading

📌 Summary

This PR fixes the NavConfig permission function to display team self service button statuses correctly.

🪢 Paired PR(s)

API

🔍 Reviewer Notes

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@ferruhcihan ferruhcihan mentioned this pull request May 9, 2025
Merged
Ani1357
Ani1357 approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by upgrading console and api on exiting cluster(v4.5.0) and it works as expected.

@ferruhcihan ferruhcihan enabled auto-merge (squash) May 13, 2025 08:16
@ferruhcihan ferruhcihan merged commit 911341c into main May 13, 2025
2 checks passed
@ferruhcihan ferruhcihan deleted the APL-757 branch May 13, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisvankekem dennisvankekem dennisvankekem approved these changes

@Ani1357 Ani1357 Ani1357 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ferruhcihan @dennisvankekem @Ani1357