Skip to content

fix: platform secret namespace length - #847

Open
dennisvankekem wants to merge 3 commits into
mainfrom
APL-1722
Open

dennisvankekem wants to merge 3 commits into
mainfrom
APL-1722

Conversation

@dennisvankekem

Copy link
Copy Markdown
Collaborator

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

Copilot AI lite review requested due to automatic review settings September 15, 2026 09:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The validation message incorrectly states that 64 characters are allowed while the limit is 63.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates platform secret namespace validation to enforce a Kubernetes-compatible 63-character maximum.

Changes:

  • Adds a .max(63) namespace constraint.
File summaries
File Description
src/pages/secrets/platform/create-edit/create-edit-platform-secrets.validator.ts Enforces the namespace length limit.
Review details

Suppressed comments (1)

src/pages/secrets/platform/create-edit/create-edit-platform-secrets.validator.ts:29

  • The new maximum-length rule is not covered by the existing namespace tests, which only exercise format failures. Please add boundary cases for a valid 63-character namespace and an invalid 64-character namespace so this Kubernetes constraint is protected from regression.
      .max(63, 'Namespace must be 64 characters or fewer')
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/pages/secrets/platform/create-edit/create-edit-platform-secrets.validator.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 15, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants