Skip to content

Conversation

@CasLubbers
Copy link
Contributor

@CasLubbers CasLubbers commented Nov 21, 2024

  • Added new defaults.gotmpl where we can store defaults for teams
  • Added 'teamApps' values for the team-ns charts where we can add specific configuration for team apps
  • Updated values schema
  • Updated values changes
    Needs to be tested/merged with:
  • api: feat: remove saveTeamApps function apl-api#587

Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except for the comment in the values-changes.yaml)

@j-zimnowoda j-zimnowoda enabled auto-merge (squash) November 27, 2024 16:31
Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-zimnowoda j-zimnowoda merged commit 64a51c3 into main Nov 27, 2024
5 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-265-team-defaults branch November 27, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants