Skip to content

fix: remove finalizers and labels from sealed secrets #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ElderMatt wants to merge 3 commits into from
Closed

fix: remove finalizers and labels from sealed secrets #2142

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c5fec2
fix: remove finalizers and labels from sealed secrets
ElderMatt May 12, 2025
f09da9d
fix: turn back removal
ElderMatt May 12, 2025
d72845c
fix: versions
ElderMatt May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions charts/sealed-secrets/crds/bitnami.com_sealedsecrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,6 @@ spec:
additionalProperties:
type: string
type: object
finalizers:
Copy link
Contributor

@j-zimnowoda j-zimnowoda May 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 3rd party CRD that the operator relies on. We can't just modify it because we can't control any side effects. Moreover these CRD properties are perfectly fine.

items:
type: string
type: array
labels:
additionalProperties:
type: string
type: object
name:
type: string
namespace:
Expand Down