fix: replace hanging kubectl delete command with api call #2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasLubbers
requested review from
Ani1357,
ferruhcihan,
j-zimnowoda and
merll
as code owners
CasLubbers
changed the title
merll
approved these changes
Dec 10, 2025
ElderMatt
approved these changes
Dec 10, 2025
Ani1357
pushed a commit
that referenced
this pull request
Dec 15, 2025
Co-authored-by: svcAPLBot <[email protected]> (cherry picked from commit dee2fdc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
The kubectl delete command kept hanging on the deletion of the argocd application knative-serving-knative-serving. This can happen with kubectl when certain resources have finalizers that they cannot be deleted.
Replacing the kubectl command with the API fixed this issue. The API seems to be have differently and just continue instead of waiting for the resource to be deleted.
For safety measures I also replaced the other kubectl commands.
🔍 Reviewer Notes
🧹 Checklist