Skip to content

fix: only add label for teamresources #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CasLubbers merged 4 commits into from
Dec 12, 2025
Merged

fix: only add label for teamresources #2792

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4850cc
fix: only add label for teamresources
CasLubbers Dec 11, 2025
7bfdcf0
Merge branch 'main' into APL-1365
svcAPLBot Dec 12, 2025
fb060ee
Merge branch 'main' into APL-1365
svcAPLBot Dec 12, 2025
b832331
Merge branch 'main' into APL-1365
svcAPLBot Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/common/repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ export interface FileMap {
loadToSpec: boolean
}

export interface AplManifest {
kind: AplKind
metadata: {
name: string
labels?: Record<string, string>
}
spec: Record<string, any>
}

export function getResourceFileName(fileMap: FileMap, jsonPath: jsonpath.PathComponent[], data: Record<string, any>) {
let fileName = 'unknown'
if (fileMap.resourceGroup === 'team') {
Expand Down Expand Up @@ -409,22 +418,27 @@ export async function saveValues(
)
}

export function renderManifest(fileMap: FileMap, jsonPath: jsonpath.PathComponent[], data: Record<string, any>) {
export function renderManifest(
fileMap: FileMap,
jsonPath: jsonpath.PathComponent[],
data: Record<string, any>,
): AplManifest {
//TODO remove this custom workaround for workloadValues
let spec = data
if (fileMap.resourceGroup === 'team') {
spec = omit(data, ['id', 'name', 'teamId'])
}
const manifest = {
const manifest: AplManifest = {
kind: fileMap.kind,
metadata: {
name: getResourceName(fileMap, jsonPath, data),
labels: {},
},
spec,
}
if (fileMap.resourceGroup === 'team') {
manifest.metadata.labels['apl.io/teamId'] = getTeamNameFromJsonPath(jsonPath)
manifest.metadata.labels = {
'apl.io/teamId': getTeamNameFromJsonPath(jsonPath),
}
}

return manifest
Expand Down
Loading