-
Notifications
You must be signed in to change notification settings - Fork 180
feat: custom kubernetes manifest in the values repo #2874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/cmd/apply-as-apps.ts
Contributor
|
Comparison of Helm chart templating output: |
Contributor
Author
|
Rebased in #2893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR enhances the functionality by responding to creation of Kubernetes manifest files in specific directories of the values repository. Files created in
env/manifests/ns/<namespace-name>/result in creation of an ArgoCD application that creates and deploys everything into the namespace with the directory name. Manifest files stored inenv/manifest/global/are intended for cluster-wide objects and therefore do not imply a target namespace, and do not create any.Removing any of the namespace directories removes the ArgoCD application as well. Removing all manifests from
globaldoes not remove the ArgoCD application, due to risks arising from deleting cluster-wide objects.In order to avoid unintended changes to unrelated ArgoCD applications, labels are added and used for selection. The platform app updates have been extended accordingly.
🔍 Reviewer Notes
Verifying that the namespace matches the directory name has been out of scope of the defined functionality, therefore the manifest can override the target deployment namespace. Additional functionality is planned to be implemented in the API.
🧹 Checklist