fix: apps not using desired storageclass in linode

[ElderMatt]

This PR fixes the storage class being used for gitea-valkey and oauth2-proxy, it is now set to linode-block-storage instead of linode-block-storage-retain. Migration has also been added to delete and recreate the pvcs.

[svcAPLBot]

Comparison of Helm chart templating output:

@@ spec.volumeClaimTemplates.v1/PersistentVolumeClaim/valkey-data.spec @@
! + one map entry added:
+ storageClassName: linode-block-storage


@@ spec.volumeClaimTemplates.v1/PersistentVolumeClaim/data.spec @@
! + one map entry added:
+ storageClassName: linode-block-storage


@@ data.VERSIONS @@
! ± value change in multiline text (one insert, one deletion)
  
- {"api":"main","aplCharts":"main","console":"main","consoleLogin":"main","core":"main","specVersion":58,"tasks":"main","tools":"main"}
+ {"api":"main","aplCharts":"main","console":"main","consoleLogin":"main","core":"main","specVersion":59,"tasks":"main","tools":"main"}




@@ versions.specVersion @@
! ± value change
- 58
+ 59

[merll]

I am fine with the main functionality of this branch, but it contains lots of unrelated changes which make it harder to read and later follow up in case someone is looking into old code. I also doubt such changes can be properly QA'ed when they are not used in any recent environment.

I would suggest either

• reverting the unrelated changes
• or removing old migrations entirely. The Istio migration is from 9 months ago and if someone still needs to upgrade a cluster this old, it should be done in smaller increments.

[merll]

I am fine with the changes if they solve the issue. What I was wondering about when reading this: We already set defaultStorageClass according to the provider linode. Did we find out why this was not used?
I am asking because I would like to avoid hiding a possibly more essential issue hidden by this patch.

[ElderMatt]

We did not set the storageClass for gitea-valkey which is why it was defaulting to linode-block-storage-retain. For Oauth2 I'm not quite sure.

[ElderMatt]

It seems for older cluster before spec version 44 we never set the defaultStorageClass so it is ''. In specVersion 44 we added the defaultStorageClass but there was no migration to set the value to linode-block-storage